[http codec] case-insensetive transfer-encoding checks #10055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxy#10041 Signed-off-by: Oleg Guba <oleg@dropbox.com>
veshij
changed the title
|
Can you merge master? caseCompare just got removed in place of an absl utility function. Otherwise LGTM. Thank you! /wait |
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
done |
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Jun 3, 2020
) (#218) Signed-off-by: Oleg Guba <oleg@dropbox.com> Co-authored-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: Oleg Guba <oleg@dropbox.com>
|
@mattklein123 do you know if this fix will be merged into |
|
@andrijaperovic |
|
@howardjohn I see tags |
|
We didn't tag istio/envoy until recently. You can look at the git logs though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleg Guba oleg@dropbox.com
Description: Per RFC7230: Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing transfer-coding names are case-insensitive:
Risk Level: Low
Testing: unit test
Docs Changes: None
Release Notes: None
Fixes #10041